Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shortcut): shortcut close env form #6518

Closed
wants to merge 7 commits into from
Closed

feat(shortcut): shortcut close env form #6518

wants to merge 7 commits into from

Conversation

kobenguyent
Copy link
Contributor

@kobenguyent kobenguyent commented Sep 17, 2023 •
edited
Loading

Motivation: have a shortcut to close the environment modal as I don't need to move my mouse and click the button.

I updated the UX a bit, when on Edit mode,

  • press the Esc to exit the edit mode then press the shortcut to save/close the modal, this behavior will be the same like user clicks on the Close button.
  • press the Esc to exit the edit mode then press Enter to save/close the modal, this behavior will be the same like user clicks on the Close button.

Resolves #6511
Resolves #6370

Screen.Recording.2023-09-17.at.19.13.08.mov

@gatzjames
Copy link
Contributor

Thanks for the PR and the support! 🙏
Closing this as we are refactoring the modals so that ESC and other accessibility for modals works out of the box everywhere. We don't want to have different hotkeys for every modal and the ones we have are going to be deleted soon

@gatzjames gatzjames closed this Sep 26, 2023
@kobenguyent kobenguyent deleted the feat-shortcut-close-env-form branch September 26, 2023 09:34
@filfreire filfreire mentioned this pull request Sep 27, 2023
Closed
@kobenguyent kobenguyent mentioned this pull request Sep 27, 2023
Closed
@ian-h-chamberlain ian-h-chamberlain mentioned this pull request Sep 27, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kobenguyent @gatzjames